Add test for `requestCollation` with `eventNotifier`, and remove one redundant step of `AddPeer`

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System

40 stars 19 forks source link

Add test for `requestCollation` with `eventNotifier`, and remove one redundant step of `AddPeer` #59

Closed mhchia closed 5 years ago

mhchia commented 5 years ago

What was wrong?

Lack of test for requestCollation with eventNotifier
One redundant step of AddPeer: onResponse

How was it fixed?

Added the test for requestCollation with eventNotifier
Remove the redundant step of onResponse
Refactor main_test.go a little bit

Cute Animal Picture

put a cute animal picture link inside the parentheses

mhchia commented 5 years ago

@NIC619 Another question: should we remove the attribute number in the Node? Currently, it is only used in runRPCServer to tag a span, just wondering if we tag it with other information like host.ID?