Closed ChihChengLiang closed 5 years ago
Note: per discussion with cc, we can also restructure request messages from Go to Python(e.g. GetCollation
). On Go side, the request message only needs to be peerID
, bytes
, and probably an indicator type
to indicate what the format of bytes
is. Then, request messages will be deserialized, handled in Python, and send the result(response
, is_message_valid
) back to Go.
Therefore, there will be four kinds of messages between Go and Python
Note:
Note: this PR works with the Python code https://github.com/mhchia/sharding-python, and can be tested together. I'm also considering to test both simultaneously. However, it needs further structure design.
@ChihChengLiang If we pass the CI, I think we should try to ship this to the codebase, since https://github.com/ethereum/py-evm/pull/1311 depends on this. What do you think?
That makes sense, is this ready for review?
@ChihChengLiang
Yes, it is. Thank you!
What was wrong?
Address #63 by adding a generic PubSub message type.
Cute Animal Picture