Add general pubsub message - Githubissues

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System

40 stars 19 forks source link

Add general pubsub message #65

Closed ChihChengLiang closed 5 years ago

ChihChengLiang commented 5 years ago

What was wrong?

Address #63 by adding a generic PubSub message type.

Cute Animal Picture

put a cute animal picture link inside the parentheses

mhchia commented 5 years ago

Note: per discussion with cc, we can also restructure request messages from Go to Python(e.g. GetCollation). On Go side, the request message only needs to be peerID, bytes, and probably an indicator type to indicate what the format of bytes is. Then, request messages will be deserialized, handled in Python, and send the result(response, is_message_valid) back to Go. Therefore, there will be four kinds of messages between Go and Python

ask_peer_for_data
peer_ask_for_data
I_broadcast
peer_broadcast

mhchia commented 5 years ago

Note:

TODO

[x] change code to send data through new RPCs
[x] remove redundant code

mhchia commented 5 years ago

Note: this PR works with the Python code https://github.com/mhchia/sharding-python, and can be tested together. I'm also considering to test both simultaneously. However, it needs further structure design.

mhchia commented 5 years ago

TODO

[x] Merge with master ~- [ ] Refactor and clean up~

mhchia commented 5 years ago

@ChihChengLiang If we pass the CI, I think we should try to ship this to the codebase, since https://github.com/ethereum/py-evm/pull/1311 depends on this. What do you think?

ChihChengLiang commented 5 years ago

That makes sense, is this ready for review?

mhchia commented 5 years ago

@ChihChengLiang
Yes, it is. Thank you!