Refactor on tests and add peer connect

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System

40 stars 19 forks source link

Refactor on tests and add peer connect #66

Closed NIC619 closed 5 years ago

NIC619 commented 5 years ago

How was it fixed?

[x] Replace NewStream with simple Connect when setting up connection with new peer, for now.
[x] Rearrange test cases: start with routing tests then request functions tests then pub/sub tests.
[x] Wait for a certain amount of time(100 millisecond) after every subscribe/unsubscribe so that peers can receive the subscription update.
[x] Remove onAddPeerRequest

Cute Animal Picture

put a cute animal picture link inside the parentheses

mhchia commented 5 years ago

Rearrange test cases: start with routing tests then request functions tests then pub/sub tests.

I'm interested in the reason why we do this

NIC619 commented 5 years ago

Rearrange test cases: start with routing tests then request functions tests then pub/sub tests.

I'm interested in the reason why we do this

No particular reason tho. The tests look a bit unorganized to me so I try to group them together and lay them in the order starting from basic network test(routing) to request function test to libp2p(pubsub) test. Let me know if this mess something up.

mhchia commented 5 years ago

No particular reason tho. The tests look a bit unorganized to me so I try to group them together and lay them in the order starting from basic network test(routing) to request function test to libp2p(pubsub) test. Let me know if this mess something up.

Get it. Thanks a lot!

mhchia commented 5 years ago

CI failed due to the timeouts in the test