Fix #64 - Githubissues

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System

40 stars 19 forks source link

Fix #64 #69

Closed NIC619 closed 5 years ago

NIC619 commented 5 years ago

How was it fixed?

[x] Start a new span if we fail to deserialize parent span context in logger.StartFromParentState instead of finish it
[x] Run script iterate_all_rpc_call.sh in CI to test if the each RPC call works
- [x] Have client side rpc call return with proper exit code if the RPC call failed so that it can trigger CI failure

Cute Animal Picture

NIC619 commented 5 years ago

NOTE: Currently tracing does not work in CI(Failed to deserialize the trace context... error) due to not able to set the global tracer. And this is because we gx-unwrite the opentracing package(related: #46 ) so there's two version of opentracing.

mhchia commented 5 years ago

And this is because we gx-unwrite the opentracing package(related: #46 ) so there's two version of opentracing.

Could you elaborate more on why two versions of opentracing leads to this issue?

NIC619 commented 5 years ago

Because we set the global tracer by opentracing.SetGlobalTracer(): https://github.com/ethresearch/sharding-p2p-poc/blob/master/main.go#L161 , so in our case we set the tracer in the gx-uw'ed opentracing while the opentracing that go-log depends on is the one that's not gx-uw'ed.