Fix security group and topology loading - Githubissues

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System

40 stars 19 forks source link

Fix security group and topology loading #82

Closed ChihChengLiang closed 5 years ago

ChihChengLiang commented 5 years ago

What was wrong?

Two issue are fixed in this PR

81 security group is not specified.
Since topology.yml is generated by a task, it can't be loaded as a global variable. The first run of the playbook would always fail and would work in the second run because topology.yml can be loaded then.

How was it fixed?

Add security group in Terraform
Don't loadtopology.yml as a global variable, use include_vars to load it once generated.

Cute Animal Picture

ChihChengLiang commented 5 years ago

Thank you for reviewing ❤

mhchia commented 5 years ago

Fixed #81