Closed mhchia closed 5 years ago
TODO
doXXX
cc @NIC619 @ChihChengLiang
@mhchia For the status code, could you return any non-0 value for any errors.
@araskachoi Yes, we have done it. Any error leads to a non-zero return value of the program
@mhchia awesome, thanks for the clarification!
No problem, you're welcome:) I think the RPCs and output should be ready. Please give us any feedback if there is still any issue.
Awesome, I will pull and test it out and see if it is good! Also, I think it would be a valuable metric to add into the json, the timestamp for when any action has been successfully completed. This way we can measure the time it takes for something to happen (especially when we start testing with network conditions and large scale tests). Please let me know your thoughts!
What was wrong?
Fix https://github.com/ethresearch/sharding-p2p-poc/issues/94
How was it fixed?
If a command succeeds, output the result directly. e.g.
If a command fails, output the error message, and set the return code as non-zero. e.g.
TODOs
Cute Animal Picture