Closed dajuguan closed 1 month ago
Is there an overall description for this PR instead of implementation details?
Is there an overall description for this PR instead of implementation details?
Description added
Is there an overall description for this PR instead of implementation details?
Description added
I may lack some context, but from the point of view of OP, it seems still quite hard to understand the rationale of the changes from the description alone, which is important if you want it to be accepted by upstream.
Is there an overall description for this PR instead of implementation details?
Description added
I may lack some context, but from the point of view of OP, it seems still quite hard to understand the rationale of the changes from the description alone, which is important if you want it to be accepted by upstream.
Great, taking another look and rethinking the rationale sounds like a good approach. A clearer explanation will definitely help with upstream acceptance.
Anymore comments? Are we good to merge?
deprecated in https://github.com/ethstorage/optimism/pull/84
We aim to address the issue of performing an attack transaction on a disputed claim by introducing a feature to decode the claims from calldata/blob in the FaultDisputeGameN.sol contract. The purpose of this feature is to allow the challenger to assess the validity of the claim and decide whether to initiate an attack.
LogFilterer
(FilterLogs
andSubscribeFilterLogs
func) interface forMultiCaller
to stub Event log responseCall
(ToBatchElemCreator
andHandleResult
func) interface for TxCall and EventCall to supporteth_getTransactionByHash
andeth_getFilterLogs
RPCsevent_stub.go
andtx_stub.go
to support mocking RPC testsGetSubClaims
function to retrieve subClaims from callData(done) and blobs(todo)