ethstorage / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
2 stars 3 forks source link

feat(op-challenger): add EventCall, TxCall and GetSubClaims #63

Closed dajuguan closed 1 month ago

dajuguan commented 2 months ago

We aim to address the issue of performing an attack transaction on a disputed claim by introducing a feature to decode the claims from calldata/blob in the FaultDisputeGameN.sol contract. The purpose of this feature is to allow the challenger to assess the validity of the claim and decide whether to initiate an attack.

blockchaindevsh commented 1 month ago

Is there an overall description for this PR instead of implementation details?

dajuguan commented 1 month ago

Is there an overall description for this PR instead of implementation details?

Description added

blockchaindevsh commented 1 month ago

Is there an overall description for this PR instead of implementation details?

Description added

I may lack some context, but from the point of view of OP, it seems still quite hard to understand the rationale of the changes from the description alone, which is important if you want it to be accepted by upstream.

dajuguan commented 1 month ago

Is there an overall description for this PR instead of implementation details?

Description added

I may lack some context, but from the point of view of OP, it seems still quite hard to understand the rationale of the changes from the description alone, which is important if you want it to be accepted by upstream.

Great, taking another look and rethinking the rationale sounds like a good approach. A clearer explanation will definitely help with upstream acceptance.

dajuguan commented 1 month ago

Anymore comments? Are we good to merge?

dajuguan commented 1 month ago

deprecated in https://github.com/ethstorage/optimism/pull/84