search

ethteck / splat

A binary splitting tool to assist with decompilation and modding projects
MIT License
170 stars 43 forks source link

[Feature Request] Automatic deduplication of symbols #412

Closed ieee802dot11ac closed 1 month ago

ieee802dot11ac commented 1 month ago

More specifically, if two symbols have the same name, the resulting output should give each unique symbol a suffix of its VRAM address. This is similar to decomp-toolkit's handling of local symbols.

ethteck commented 1 month ago

There are legitimate reasons two symbols might have the same name. Splat shouldn't be modifying names that are manually defined by the user.

For generated names, we have ways to adding the vram address, rom address, custom suffix/prefix, etc (the symbol name format option). Do these not work for you?

ieee802dot11ac commented 1 month ago

I genuinely had no clue those options existed. Thanks!

ethteck commented 1 month ago

ah, np! glad to help :)