search

ethteck / splat

A binary splitting tool to assist with decompilation and modding projects
MIT License
170 stars 43 forks source link

Warning about the start of the .rodata section doesn't seem disableable #416

Closed ethteck closed 1 day ago

ethteck commented 5 days ago

https://github.com/ethteck/splat/blob/main/src/splat/segtypes/common/data.py#L146

AngheloAlf commented 2 days ago

Should we add an option to turn off the warning as a whole or just per segment? Or both?

Another idea besides being able to turn off this warning is to detect if the jumptable is used by a hasm file and ignore the suggestion if that's the case

ethteck commented 2 days ago

I think any warning emitted should be configurable at some level, even if it's not per-warning type. but yeah I think global + per segment is grood

AngheloAlf commented 2 days ago

I think we should add a way to turn it off. The other suggestion is just an extra besides the toggle option

ethteck commented 1 day ago

gotcha, makes sense. yeh I agree with the idea I think