search

ethul / purescript-angular

AngularJS 1.2 bindings for PureScript (currently in the experimental stage)
MIT License
23 stars 3 forks source link

Tighten effect types on modifyScope and modifyThis #19

Closed dylex closed 9 years ago

dylex commented 9 years ago

Currently these functions effectively allow unsafeInterleaveEff, but have no reason to. They could have the more restrictive types that only allow effects already in scope:

modifyScope :: forall e a b. ({ | a} -> Eff e { | b }) -> Scope a -> ReadWriteEff e Unit
modifyThis :: forall e a b. ({ | a } -> Eff e { | b }) -> This a -> ReadWriteEff e Unit
ethul commented 9 years ago

Good call