search

ethul / purescript-react-redux

MIT License
15 stars 6 forks source link

purescript-react-redux not listed on pursuit #11

Closed coot closed 6 years ago

ethul commented 7 years ago

Good call! I will publish to pursuit once #10 is merged in. Thanks!

felixSchl commented 6 years ago

Hey, could we get this onto pursuit now? I am trying to publish purescript-redux-saga which builds on top of this project, but whenever I try to publish it, I get the following error:

There is a problem with your package, which meant that it could not be                                                                               
published.                                                                                                                                           
Details:                                                                                                                                             
  Compile error:                                                                                                                                     
    Error found:                                                                                                                                     
    in module React.Redux                                                                                                                   
    at /home/felix/projects/purescript-redux-saga/bower_components/purescript-react-redux/src/React/Redux.purs line 22, column 1 - line 22, column 52

      Module Data.Record.Class was not found.                                                                                               
      Make sure the source file exists, and that it has been provided as an input to the compiler.                                                   

    See https://github.com/purescript/documentation/blob/master/errors/ModuleNotFound.md for more information,                                       
    or to contribute content related to this error.

I think if you tried to publish this library you would get a similar error because of the dependency on a forked version of purescript-record. Could we just vendor the Data.Record.Class module under a different name for now since it's usage is fairly localized from what I can tell.

ethul commented 6 years ago

Definitely. Apologies for the delay on this. I was waiting for Data.Record.Class, but I don't mind bringing the relevant code into React.Redux.

felixSchl commented 6 years ago

Thanks!

ethul commented 6 years ago

Welcome! The package is now on Pursuit.

https://pursuit.purescript.org/packages/purescript-react-redux