ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
351 stars 71 forks source link

`MessagingConfig` creation UX updates `ApplicationConfig` vars with no submission #2886

Open seanpreston opened 1 year ago

seanpreston commented 1 year ago

Bug Description

When on the new view to Configure your messaging provider, toggling the Twilio SMS radio button causes three HTTP requests to be sent:

Fides should not:

Steps to Reproduce

  1. Navigate to /management/about and toggle on the feature flags
  2. Navigate to /privacy-requests/configure/messaging and select each radio button, notice that on selecting Twilio SMS

Expected behavior

A reasonable expectation here is to configure these objects within Fides, and have some explicit opt-in from the user to make the other changes.

Screenshots

Screenshot 2023-03-20 at 18 45 46

adamsachs commented 1 year ago

i just want to note that https://github.com/ethyca/fides/issues/2787 is a UI feature we know we need, and i think it would effectively resolve this problem: enabling subject identity verification would be triggered by a dedicated UI component that clearly and explicitly changes the setting, rather than being tied to the radio button click (with no real indication to the end user, which i think is ultimately causing the confusing behavior here.