Open seanpreston opened 1 year ago
i just want to note that https://github.com/ethyca/fides/issues/2787 is a UI feature we know we need, and i think it would effectively resolve this problem: enabling subject identity verification would be triggered by a dedicated UI component that clearly and explicitly changes the setting, rather than being tied to the radio button click (with no real indication to the end user, which i think is ultimately causing the confusing behavior here.
Bug Description
When on the new view to
Configure your messaging provider
, toggling theTwilio SMS
radio button causes three HTTP requests to be sent:PATCH /api/v1/config
withPUT /api/v1/messaging/default
with{"service_type": "twilio_text"}
GET /api/v1/messaging/default/twilio_text
Fides should not:
subject_identity_verification_required
toTrue
when there is no way or verify identities (because there is no messaging provider)Steps to Reproduce
/management/about
and toggle on the feature flags/privacy-requests/configure/messaging
and select each radio button, notice that on selectingTwilio SMS
Expected behavior
A reasonable expectation here is to configure these objects within Fides, and have some explicit opt-in from the user to make the other changes.
Screenshots