ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
351 stars 71 forks source link

fides push should push custom taxonomy first #2959

Open mfbrown opened 1 year ago

mfbrown commented 1 year ago

When you do a fides push, it doesn't seem like there is a preferred order in which resources are pushed. This can lead to failures if a system or dataset is pushed before custom taxonomy extensions, and relies on a custom taxonomy element.

I think it would be better if fides push looked for any taxonomy extensions and always pushed those first, then pushed systems, datasets, etc.

rsilvery commented 10 months ago

@mfbrown is this still an issue?

mfbrown commented 10 months ago

Yes. Anytime using Fides push to push a large manifest file of multiple types of Fides resources, there's no guarantee that taxonomy is pushed first.

rsilvery commented 10 months ago

What's the impact?

mfbrown commented 10 months ago

Whenever systems or datasets that reference custom taxonomy elements are pushed first, the whole push fails, since you can't reference taxonomy elements that don't exist.