ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
359 stars 72 forks source link

Update main client dependencies to next major versions: React 18, NextJS 13, Chakra 2 #3173

Open NevilleS opened 1 year ago

NevilleS commented 1 year ago

Description

We're falling behind from the latest-and-greatest, and there are some really excellent improvements in the latest versions of our "main" client dependencies:

NextJS 13+ supports some important improvements to API routes and bundling optimizations (like transpilePackages) that we'll need to keep building our Fides UI components quickly without having to start relying on backports and other 3rd-party libs.

Chakra 2+ is better all around, including lots of little hard-won UX details we might not notice at first. For example, I noticed in 2.2+ they improved the "focus" indicator to only display when navigating the page with an a11y device, making those annoying blue borders on some of our buttons and form elements disappear πŸ‘

Acceptance Criteria

Implementation Notes/Details

Lots of tiny details to work through on this one, and you never really know what's going to be easy and hard. Overall I think the NextJS update looks the trickiest and involves a couple codemods like these:

See https://nextjs.org/docs/advanced-features/codemods#nextjs-13 for notes on those.

rsilvery commented 1 year ago

@adamsachs have we done these updates?

adamsachs commented 1 year ago

@adamsachs have we done these updates?

needs confirmation from a FE dev, but looking at our package.jsons it does not seem like we've made these updates.