search

ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
355 stars 73 forks source link

revert to undefined instead of empty object #5309

Closed gilluminate closed 1 week ago

gilluminate commented 1 week ago

Closes #

Description Of Changes

In version 2.44 of the Privacy Center, the value of the default experience was set to {} (see https://github.com/ethyca/fides/pull/5230/files#diff-ba7bb0c80dbf370b49c211bf0e888dc34cf0f7a713e2b4b685d98b0b46b25014R155-R158).

This causes problems specifically for clients not using prefetch and CDNs as now Fides.js believe that the user received a valid, albeit empty experience and then does not call the Fides API to check for experiences.

Reverting back to undefined for that reason.

Code Changes

Pre-Merge Checklist

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/9GB6mx3XvHSsLCrW4tmwFWenv9m6)) | [Visit Preview](https://fides-plus-nightly-git-prod-2733-privacy-center-f-2bab63-ethyca.vercel.app) | | Sep 20, 2024 8:39pm |
cypress[bot] commented 1 week ago

fides    Run #10037

Run Properties:  status check passed Passed #10037  •  git commit c9c7e3c190 ℹ️: Merge eeeefe9d220ea702641e12bb05c9ba72bf8c6bb5 into 9911451e6e477c3ec4565f15652b...
Project fides
Branch Review refs/pull/5309/merge
Run status status check passed Passed #10037
Run duration 00m 38s
Commit git commit c9c7e3c190 ℹ️: Merge eeeefe9d220ea702641e12bb05c9ba72bf8c6bb5 into 9911451e6e477c3ec4565f15652b...
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎
cypress[bot] commented 1 week ago

fides    Run #10039

Run Properties:  status check passed Passed #10039  •  git commit 257cf72f54: revert to undefined instead of empty object (#5309)
Project fides
Branch Review main
Run status status check passed Passed #10039
Run duration 00m 38s
Commit git commit 257cf72f54: revert to undefined instead of empty object (#5309)
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎