ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
355 stars 73 forks source link

better handling of empty storage secrets in aws_util #5347

Open adamsachs opened 1 day ago

adamsachs commented 1 day ago

Closes PROD-2839

Description Of Changes

Haven't done any manual testing yet, which should likely be done before we merge.

Code Changes

Steps to Confirm

Pre-Merge Checklist

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/FMsnnv3VHLE363VipzaSVmDaoYWD)) | | | Oct 3, 2024 4:08pm |
cypress[bot] commented 1 day ago

fides    Run #10276

Run Properties:  status check passed Passed #10276  •  git commit 7312caf9e8 ℹ️: Merge 9367e04cf205bdc534a37caec857952c9285e9ce into c0fc642c0b6abc9e66e32b26a13f...
Project fides
Branch Review refs/pull/5347/merge
Run status status check passed Passed #10276
Run duration 00m 39s
Commit git commit 7312caf9e8 ℹ️: Merge 9367e04cf205bdc534a37caec857952c9285e9ce into c0fc642c0b6abc9e66e32b26a13f...
Committer Adam Sachs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎