search

ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
361 stars 72 forks source link

Fix OpenAPI TypeScript types #5437

Closed jpople closed 3 weeks ago

jpople commented 4 weeks ago

Closes HJ-17

Code Changes

Pre-Merge Checklist

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/3k59cYDzhQ7cLnXPJUMJkes2DK9d)) | [Visit Preview](https://fides-plus-nightly-git-jpople-hj-17fix-fe-types-ethyca.vercel.app) | | Oct 30, 2024 3:00pm |
cypress[bot] commented 4 weeks ago

fides    Run #10689

Run Properties:  status check passed Passed #10689  •  git commit a88727a992 ℹ️: Merge 56cbbeed278c4edd220bf1d2d6da4d16d70d3f9d into eac2542b07b76ebc9a8a15386a1f...
Project fides
Branch Review refs/pull/5437/merge
Run status status check passed Passed #10689
Run duration 00m 37s
Commit git commit a88727a992 ℹ️: Merge 56cbbeed278c4edd220bf1d2d6da4d16d70d3f9d into eac2542b07b76ebc9a8a15386a1f...
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎
jpople commented 3 weeks ago

@gilluminate General regression, the only real manual change aside from adding some fallback []s was changing classifications (in the old classifier flow, not D&D) to rank based on score instead of aggregated_score which no longer exists.

cypress[bot] commented 3 weeks ago

fides    Run #10720

Run Properties:  status check passed Passed #10720  •  git commit 008cf6818d: Fix OpenAPI TypeScript types (#5437)
Project fides
Branch Review main
Run status status check passed Passed #10720
Run duration 00m 40s
Commit git commit 008cf6818d: Fix OpenAPI TypeScript types (#5437)
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎