ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

Fix nested field name displays in D&D tables #5439

Closed jpople closed 2 weeks ago

jpople commented 3 weeks ago

Closes HJ-59

Description Of Changes

Changes D&D's default result cell to display "un-nested" subfield names with multiple parts derived from the URN instead of just the "terminal" field's name.

Before: Screenshot 2024-10-31 at 02 37 57

After: Screenshot 2024-10-31 at 02 38 19

Non-subfield resources' naming is unchanged.

Code Changes

Steps to Confirm

Pre-Merge Checklist

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗ī¸Ž

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview đŸ’Ŧ Add feedback Nov 5, 2024 9:07pm
cypress[bot] commented 3 weeks ago

fides    Run #10803

Run Properties:  status check passed Passed #10803  •  git commit 0ed2890776 ℹī¸: Merge 3f66b14d505d5215f9a9d430570c725a28aa6e19 into ba4c825f21a3fc44507b071193e3...
Project fides
Branch Review refs/pull/5439/merge
Run status status check passed Passed #10803
Run duration 00m 39s
Commit git commit 0ed2890776 ℹī¸: Merge 3f66b14d505d5215f9a9d430570c725a28aa6e19 into ba4c825f21a3fc44507b071193e3...
Committer jpople
View all properties for this run ↗ī¸Ž

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗ī¸Ž
cypress[bot] commented 2 weeks ago

fides    Run #10808

Run Properties:  status check passed Passed #10808  •  git commit 44054e7b96: Fix nested field name displays in D&D tables (#5439)
Project fides
Branch Review main
Run status status check passed Passed #10808
Run duration 00m 38s
Commit git commit 44054e7b96: Fix nested field name displays in D&D tables (#5439)
Committer jpople
View all properties for this run ↗ī¸Ž

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗ī¸Ž