HJ-138 - Added a security setting that must be set to true to enable the access request download feature

andres-torres-marroquin commented 2 weeks ago

Closes #HJ-138

Description Of Changes

Added a security setting that must be set to true to enable the access request download feature

Code Changes

[ ] Updated route get_access_results_urls and its tests

Steps to Confirm

[ ] Enable "Download access request results" on "About Fides"
[ ] Setup a variable on .env: FIDES__SECURITY__SUBJECT_REQUEST_DOWNLOAD_UI_ENABLED as true or false
[ ] Create a privacy request on the demo site
[ ] Open it on the Admin UI
[ ] See the button being disabled if FIDES__SECURITY__SUBJECT_REQUEST_DOWNLOAD_UI_ENABLED==false

Screenshot 2024-11-04 at 9 13 53 a m

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:
- [ ] documentation complete, PR opened in fidesdocs
- [ ] documentation issue created in fidesdocs
- [ ] if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated
If there are any database migrations:
- [ ] Ensure that your downrev is up to date with the latest revision on main
- [ ] Ensure that your downgrade() migration is correct and works
- [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

cypress[bot] commented 2 weeks ago

fides Run #10773

Run Properties: Passed #10773 • 37480ed2c0 ℹ️: Merge a5905908884bca6b21b85ab78645e21a5debac47 into e3d2fe8c03f4294a9425bdacdf9d...

Project	`fides`
Branch Review	`refs/pull/5451/merge`
Run status	`Passed #10773`
Run duration	`00m 38s`
Commit	`37480ed2c0 ℹ️: Merge a5905908884bca6b21b85ab78645e21a5debac47 into e3d2fe8c03f4294a9425bdacdf9d...`
Committer	`Andres Torres`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`4`
View all changes introduced in this branch ↗︎

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.47%. Comparing base (e5f240d) to head (a590590). Report is 3 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #5451 +/- ## ======================================= Coverage 85.47% 85.47% ======================================= Files 384 384 Lines 24116 24119 +3 Branches 2624 2625 +1 ======================================= + Hits 20612 20615 +3 Misses 2950 2950 Partials 554 554 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 2 weeks ago

fides Run #10778

Run Properties: Passed #10778 • dc3bfed3fc: HJ-138 - Added a security setting that must be set to true to enable the access ...

Project	`fides`
Branch Review	`main`
Run status	`Passed #10778`
Run duration	`00m 37s`
Commit	`dc3bfed3fc: HJ-138 - Added a security setting that must be set to true to enable the access ...`
Committer	`Andres Torres`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`4`
View all changes introduced in this branch ↗︎

ethyca / fides