Apply updated taxonomy labels and patterns to other columns in the data map report

ethyca / fides

The Privacy Engineering & Compliance Framework

https://ethyca.com/docs

Apache License 2.0

360 stars 72 forks source link

Apply updated taxonomy labels and patterns to other columns in the data map report #5464

Closed gilluminate closed 2 weeks ago

gilluminate commented 2 weeks ago

Closes HJ-39

Description Of Changes

Any column in Data map report that uses a badge should have the newer badge look/feel

Code Changes

Add badgeProps={{ variant: "outline" }} to each column using the GroupCountBadgeCell component as the cell renderer

Steps to Confirm

Create a system that populates each of the following columns in the Data map report

Data use
Data category
Data subjects
Data Stewards (can this even be done?
Destinations
Features
Sources
Legal Basis for profiling
Legal Basis for transfers
Responsibilities
Shared Categories
System Dependencies
System Undeclared data categories
Data use undeclared categories
Cookies

Ensure all of those columns have the new, consistent looking badge.

Note: Data use and Data category columns already have this new look/feel, so you can reference those for consistency with the update to all of the other columns for this story.

CleanShot 2024-11-05 at 14 05 21@2x

Pre-Merge Checklist

[x] All CI Pipelines Succeeded
[x] Issue Requirements are Met
[x] Update CHANGELOG.md

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 10:47pm

cypress[bot] commented 2 weeks ago

fides Run #10810

Run Properties: Passed #10810 • 9a7a5028a5 ℹ️: Merge 0d849ab379d91b0361b10dc9fa553b8e521a7825 into 44054e7b96e6d820363abdd318c5...

Project	`fides`
Branch Review	`refs/pull/5464/merge`
Run status	`Passed #10810`
Run duration	`00m 39s`
Commit	`9a7a5028a5 ℹ️: Merge 0d849ab379d91b0361b10dc9fa553b8e521a7825 into 44054e7b96e6d820363abdd318c5...`
Committer	`Jason Gill`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`4`
View all changes introduced in this branch ↗︎

jpople commented 2 weeks ago

Screenshot 2024-11-05 at 16 11 39

Mostly looks good to me-- small nitpick, but some longer badge contents are getting cut off at the default column width, which seems annoying if it's easy to fix. Not a huge deal if not though.

gilluminate commented 2 weeks ago

some longer badge contents are getting cut off at the default column width

@jpople good call. I added the width: "auto" property to each of these as well to help with that. I had forgotten that was part of what made those work well

cypress[bot] commented 2 weeks ago

fides Run #10811

Run Properties: Passed #10811 • c11da91030: Apply updated taxonomy labels and patterns to other columns in the data map repo...

Project	`fides`
Branch Review	`main`
Run status	`Passed #10811`
Run duration	`00m 36s`
Commit	`c11da91030: Apply updated taxonomy labels and patterns to other columns in the data map repo...`
Committer	`Jason Gill`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`4`
View all changes introduced in this branch ↗︎