ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

Running static checks properly #5471

Closed Vagoasdf closed 2 weeks ago

Vagoasdf commented 2 weeks ago

Running Static Checks for PRs 5452 and 5429

Description Of Changes

Pre-Merge Checklist

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/5srHECLPEF3QCRxfH9ZCTUmwba7v)) | | | Nov 6, 2024 6:42pm |
cypress[bot] commented 2 weeks ago

fides    Run #10848

Run Properties:  status check passed Passed #10848  •  git commit 4909f3aa2b ℹ️: Merge b8b2ea18dc77ec6ea9e5cfb221b9c88b9604a2d8 into 0e36182fd8337242ecf5b874ab95...
Project fides
Branch Review refs/pull/5471/merge
Run status status check passed Passed #10848
Run duration 00m 37s
Commit git commit 4909f3aa2b ℹ️: Merge b8b2ea18dc77ec6ea9e5cfb221b9c88b9604a2d8 into 0e36182fd8337242ecf5b874ab95...
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎
cypress[bot] commented 2 weeks ago

fides    Run #10849

Run Properties:  status check passed Passed #10849  •  git commit 20b3a9c996: Running static checks properly (#5471)
Project fides
Branch Review main
Run status status check passed Passed #10849
Run duration 00m 38s
Commit git commit 20b3a9c996: Running static checks properly (#5471)
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.30%. Comparing base (0e36182) to head (b8b2ea1). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...de_implementations/salesforce_request_overrides.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5471 +/- ## ======================================= Coverage 85.30% 85.30% ======================================= Files 386 386 Lines 24206 24206 Branches 2636 2636 ======================================= Hits 20649 20649 Misses 3004 3004 Partials 553 553 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.