ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

Support new "All" GPP approach #5480

Closed gilluminate closed 2 weeks ago

gilluminate commented 2 weeks ago

Closes HJ-167, HJ-84

Description Of Changes

Code Changes

Steps to Confirm

  1. Visit the Consent Settings page in Admin UI (/settings/consent)
  2. Ensure that the GPP status is "Enabled"
  3. In the GPP U.S. section, select the new, 3rd option "Enable US National and State-by-State notices"
  4. Notice the [Save] button at the bottom of the screen is no longer taking up the entire width of the page. Click it to save the option selected.
  5. Visit the Notices page (/consent/privacy-notices)
  6. Notice that both US State and US National notices are available
  7. Ensure that a state-by-state targeted advertising notice and a national targeted advertising notice are enabled
  8. Visit the Experience page (/consent/privacy-experience)
  9. Assign the state-by-state targeted advertising notice to a privacy experience with the locations of CA, UT, CO, VA, CT
  10. Assign the national targeted advertising notices to a privacy experience with the locations of MT, TX, IA, OR, WA
  11. Visit the cookie house from Colorado and inspect the GPP API in the browser console to make sure that the parsed section is CO (uscov1), and the CO section number is listed in the applicableSections property __gpp('ping', (data) => {console.log(data)})
  12. Visit the cookie house from MT and inspect the GPP API in the browser console to make sure that the parsed section is USNAT (usnatv1), and the USNAT section number is listed in the applicableSections property
  13. Visit the Privacy Center demo page and load Fides.js with the gpp=true param from a location that is not configured in either experience and make sure the applicableSections value is [-1] (eg. /fides-js-demo.html?geolocation=us-id&gpp=true for Idaho).

Pre-Merge Checklist

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/ApYUZrNTcokZpDcHTsv5Gv5W2y14)) | [Visit Preview](https://fides-plus-nightly-git-gill-hj-167gpp-allow-natio-044355-ethyca.vercel.app) | | Nov 8, 2024 7:15pm |
cypress[bot] commented 2 weeks ago

fides    Run #10902

Run Properties:  status check passed Passed #10902  •  git commit 52d6a24d16 ℹ️: Merge 593b7c8ad194665d8098fd7b70695d57c3016327 into 306202ef00da7a5e73701663602a...
Project fides
Branch Review refs/pull/5480/merge
Run status status check passed Passed #10902
Run duration 00m 38s
Commit git commit 52d6a24d16 ℹ️: Merge 593b7c8ad194665d8098fd7b70695d57c3016327 into 306202ef00da7a5e73701663602a...
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎
cypress[bot] commented 2 weeks ago

fides    Run #10903

Run Properties:  status check passed Passed #10903  •  git commit 993aea1a4c: Support new "All" GPP approach (#5480)
Project fides
Branch Review main
Run status status check passed Passed #10903
Run duration 00m 41s
Commit git commit 993aea1a4c: Support new "All" GPP approach (#5480)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎