Closed galvana closed 1 week ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Passed #11008
•
0f77bdd5a8 ℹ️: Merge 649e6f0f047418813371c37e2b8604517bd5fdda into 52ac3301bef835ab4671d258eb80...
Project |
fides
|
Branch Review |
refs/pull/5486/merge
|
Run status |
Passed #11008
|
Run duration | 00m 37s |
Commit |
0f77bdd5a8 ℹ️: Merge 649e6f0f047418813371c37e2b8604517bd5fdda into 52ac3301bef835ab4671d258eb80...
|
Committer | Adrian Galvan |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Attention: Patch coverage is 52.00000%
with 12 lines
in your changes missing coverage. Please review.
Project coverage is 85.18%. Comparing base (
d14d031
) to head (48b63eb
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/fides/api/service/connectors/query_config.py | 23.07% | 10 Missing :warning: |
src/fides/api/service/connectors/sql_connector.py | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you add a Changelog row as well @galvana?
Passed #11009
•
77e87be5fe: Adding namespace support for Snowflake (#5486)
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #11009
|
Run duration | 00m 38s |
Commit |
77e87be5fe: Adding namespace support for Snowflake (#5486)
|
Committer | Adrian Galvan |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Closes LA-120
Description Of Changes
Updates the
SnowflakeConnector
to use a namespaced query config. This allows queries to specify the correct database name and schema without relying on these values from the connectionconfig.Code Changes
SnowflakeNamespaceMeta
schema (database_name
andschema
)SnowflakeConnector
andSnowflakeQueryConfig
Steps to Confirm
Load datasets
Configure integration
Snowflake
and hit Save.Snowflake
from the drop down. Add the credentials from 1password (it's ok to skip Private key, Passphrase, and Role).snowflake_example_test_dataset
to the integration.Run tests
customer-1@example.com
. Approve the request and verify it is successful. This is the existing functionality.Database
andSchema
, hit Save. Submit another privacy request, it should fail this time.snowflake_example_test_dataset
and linksnowflake_example_test_dataset_with_namespace
, hit Save. Submit another request, the request should use the namespace values and succeed.Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works