ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

add loading state to Notice switches #5489

Closed gilluminate closed 1 week ago

gilluminate commented 1 week ago

Closes HJ-189

Description Of Changes

Toggling the switches in the Notices table can sometimes take a moment or two and we aren't giving any feedback to the user. Now that we have toggle switches with loading states (thanks, Ant!) let's take advantage of that.

https://www.loom.com/share/c4da372b70ab46d89c01324a24fa8e53

Code Changes

Steps to Confirm

  1. Visit Manage privacy notices page /consent/privacy-notices
  2. Toggle some notices and notice the spinner while it loads (even after the confirmation modal)

Pre-Merge Checklist

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/J39hALQhSij3ftiqp2gUSTJYYnRx)) | [Visit Preview](https://fides-plus-nightly-git-gill-hj-189enable-disable-ed1c38-ethyca.vercel.app) | | Nov 12, 2024 8:06pm |
cypress[bot] commented 1 week ago

fides    Run #10962

Run Properties:  status check passed Passed #10962  •  git commit 730b9cc1b7 ℹ️: Merge f6522ea1b8ac385fe583d5ff8bbcb673e1f68194 into dd3ffd5e83aa6dd54f8c1bb159ea...
Project fides
Branch Review refs/pull/5489/merge
Run status status check passed Passed #10962
Run duration 00m 37s
Commit git commit 730b9cc1b7 ℹ️: Merge f6522ea1b8ac385fe583d5ff8bbcb673e1f68194 into dd3ffd5e83aa6dd54f8c1bb159ea...
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎
cypress[bot] commented 1 week ago

fides    Run #10963

Run Properties:  status check passed Passed #10963  •  git commit 2a3ec6c4cb: add loading state to Notice switches (#5489)
Project fides
Branch Review main
Run status status check passed Passed #10963
Run duration 00m 38s
Commit git commit 2a3ec6c4cb: add loading state to Notice switches (#5489)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎