ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

Draft: LA-129 Make database fields optional for Snokflake to allow D&D to ha… #5490

Closed lucanovera closed 1 week ago

lucanovera commented 1 week ago

…ppen on multiple databases

Closes #

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/Gnj9f36xsRcyhGyGXJVS4C3JN34W)) | [Visit Preview](https://fides-plus-nightly-git-la-129-snowflake-monitor-c-ef2ac2-ethyca.vercel.app) | | Nov 13, 2024 3:26pm |
cypress[bot] commented 1 week ago

fides    Run #10975

Run Properties:  status check passed Passed #10975  •  git commit 8204bb6d46 ℹ️: Merge c6c5ff25a1c6d435cfb461b400fa9f25bcf2680a into 2a3ec6c4cba0ba53aa35681e7bdb...
Project fides
Branch Review refs/pull/5490/merge
Run status status check passed Passed #10975
Run duration 00m 37s
Commit git commit 8204bb6d46 ℹ️: Merge c6c5ff25a1c6d435cfb461b400fa9f25bcf2680a into 2a3ec6c4cba0ba53aa35681e7bdb...
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.20%. Comparing base (2a3ec6c) to head (c6c5ff2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5490 +/- ## ======================================= Coverage 85.20% 85.20% ======================================= Files 386 386 Lines 24247 24247 Branches 2644 2644 ======================================= Hits 20660 20660 Misses 3033 3033 Partials 554 554 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.