ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
361 stars 72 forks source link

LA-33 use shopify graphql api #5499

Closed Vagoasdf closed 1 week ago

Vagoasdf commented 1 week ago

Closes LA#33

Pairs With https://github.com/ethyca/fidesplus/pull/1728

Description Of Changes

We are updating the Shopify Integration to use GraphQL. This allows us to save processing power by running specific requests with the data we want to use, and we also keep up to date with the current versions of the API, upgrading from one dating to 2022 to one recent from november 2024. This also allow us to leverage the dedicated customer data removal endpoint from shopify, instead of relying on masking each on of the customer orders and addressed directly

Code Changes

Steps to Confirm

  1. Pair with the new Config and Dataset from fidesplus PR https://github.com/ethyca/fidesplus/pull/1728
  2. Create a new Shopify integration
  3. Make an access request with the identity connectors@ethyca.com
  4. Check the data is properly accessed
  5. make a delete request with the identity connectors@ethyca.com
  6. On Postman, cancel the erasure requests corresponding to the customers recognized by connectors@ethyca.com:
    • gid://shopify/Customer/5692184199261
    • gid://shopify/Customer/5753359859805
    • gid://shopify/Customer/5765598150749
    • gid://shopify/Customer/5829835063389

(Note: If we attempt to create another delete request without canceling the previous ones, the request will fail with the error Failed to request customer data erasure )

Pre-Merge Checklist

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/E7oegSfFHBTSZidU7RQxyMMnP4yE)) | [Visit Preview](https://fides-plus-nightly-git-la-33-use-shopify-graphql-api-ethyca.vercel.app) | | Nov 18, 2024 6:42pm |
cypress[bot] commented 1 week ago

fides    Run #11048

Run Properties:  status check passed Passed #11048  •  git commit 0ae0cad799 ℹ️: Merge 56044f722896a1a2a4a6095b93e5c39cc50f699f into 861201b96ceca626ca47de6bfb31...
Project fides
Branch Review refs/pull/5499/merge
Run status status check passed Passed #11048
Run duration 00m 37s
Commit git commit 0ae0cad799 ℹ️: Merge 56044f722896a1a2a4a6095b93e5c39cc50f699f into 861201b96ceca626ca47de6bfb31...
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 24.80000% with 94 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (1c8b2d7) to head (83e3d1b). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...erride_implementations/shopify_request_override.py 24.80% 94 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5499 +/- ## ========================================== - Coverage 85.18% 84.87% -0.31% ========================================== Files 387 388 +1 Lines 24265 24390 +125 Branches 2646 2661 +15 ========================================== + Hits 20669 20700 +31 - Misses 3042 3136 +94 Partials 554 554 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

cypress[bot] commented 1 week ago

fides    Run #11051

Run Properties:  status check passed Passed #11051  •  git commit b8add27de8: LA-33 use shopify graphql api (#5499)
Project fides
Branch Review main
Run status status check passed Passed #11051
Run duration 00m 37s
Commit git commit b8add27de8: LA-33 use shopify graphql api (#5499)
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎