Closed Vagoasdf closed 1 week ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Passed #11048
•
0ae0cad799 ℹ️: Merge 56044f722896a1a2a4a6095b93e5c39cc50f699f into 861201b96ceca626ca47de6bfb31...
Project |
fides
|
Branch Review |
refs/pull/5499/merge
|
Run status |
Passed #11048
|
Run duration | 00m 37s |
Commit |
0ae0cad799 ℹ️: Merge 56044f722896a1a2a4a6095b93e5c39cc50f699f into 861201b96ceca626ca47de6bfb31...
|
Committer | Bruno Gutierrez Rios |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Attention: Patch coverage is 24.80000%
with 94 lines
in your changes missing coverage. Please review.
Project coverage is 84.87%. Comparing base (
1c8b2d7
) to head (83e3d1b
). Report is 2 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...erride_implementations/shopify_request_override.py | 24.80% | 94 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Passed #11051
•
b8add27de8: LA-33 use shopify graphql api (#5499)
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #11051
|
Run duration | 00m 37s |
Commit |
b8add27de8: LA-33 use shopify graphql api (#5499)
|
Committer | Bruno Gutierrez Rios |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Closes LA#33
Pairs With https://github.com/ethyca/fidesplus/pull/1728
Description Of Changes
We are updating the Shopify Integration to use GraphQL. This allows us to save processing power by running specific requests with the data we want to use, and we also keep up to date with the current versions of the API, upgrading from one dating to 2022 to one recent from november 2024. This also allow us to leverage the dedicated customer data removal endpoint from shopify, instead of relying on masking each on of the customer orders and addressed directly
Code Changes
Steps to Confirm
(Note: If we attempt to create another delete request without canceling the previous ones, the request will fail with the error Failed to request customer data erasure )
Pre-Merge Checklist
CHANGELOG.md
updated