search

ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

Migrate custom selects (Chakra -> Ant) #5502

Closed gilluminate closed 1 day ago

gilluminate commented 1 week ago

Closes HJ-160

Description Of Changes

Code Changes

Steps to Confirm

  1. Visit System inventory where an integration has been configured (Iterable)
  2. Switch to the "Integrations" tab
  3. Ensure the "Request types" multi-select uses the new Select
  4. Now switch to the "Data uses" tab
  5. Click one of the options or the [Add data use +] button
  6. In the modal, the "Data use," "Data categories," "Data subjects," "Legal basis for processing," "Features," "Dataset references," and "Cookies" fields all use the new Select
  1. Visit the Manage your vendors page (/consent/configure)
  2. Click [Add Vendors] and then [Add custom vendor]
  3. All fields in this modal are using the new Select
  4. Close the modal and return to the Manage your vendors page
  5. open a Vendor that has more than one TCF Purpose
  6. Badges should appear here where there used to be a disabled Select instance with badges inside it.

CleanShot 2024-11-14 at 15 15 55@2x

  1. Visit Manage custom fields (/settings/custom-fields)
  2. Add a new custom field
  3. "Location" and "Field type" are both using the new Select.
  4. Go ahead and create 1 for Single Select
  5. Go to the Add system form and at the very bottom under Custom fields you should see the custom field you just created and it should be using the new Select.
  1. Go to Add Systems (/add-systems)
  2. Click the "Add a System" button
  3. The "Dataset references" field is using the new Select (everything else on this page was updated in the previous PR)
  4. Now on the Add Systems page, Click the "Scan your infrastructure (AWS)" button
  5. The AWS Region field is using the new Select
  1. Go to add New Privacy Notice (/consent/privacy-notices/new)
  2. "Consent mechanism," "Data use," and "Enforcement level" are all using the new Select
  1. Go to Integrations (/integrations)
  2. Click [Add Integration] button
  3. Click [Configure] button on one of the options
  4. The "System" field is using the new Select
  5. Close the modal and [Manage] one of the existing integrations (or crate one on the previous step)
  6. Click the "Data discovery" tab
  7. Click the [Add monitor] button
  8. the "Automatic execution frequency" field is using the new Select
  1. Go to Organizations Management (/settings/organization)
  2. Click [Add SSO Provider]
  3. The "Provider" field is using the new Select
  1. Go to create a new Experience (/consent/privacy-experience/new)
  2. The "Experience Type" field is using the new Select
  3. Use that to select a "Banner and modal" type
  4. The now visible "Banner options" field uses the new Select
  1. Go to Privacy requests (/privacy-requests)
  2. Click [Create request]
  3. The "Request type" field is using the new Select
  4. Click the [filter] button at the top of the table
  5. The "Status" and "Request type" fields are using the new Select
  1. Go to the (hidden) Configure Storage page (/privacy-requests/configure/storage)
  2. "Format," and "Auth method" are using the new Select
  1. Go to Properties (/properties)
  2. Click [Add Property] button
  3. The "Type" field is using the new Select
  1. Go to the Data map report (/reporting/datamap)
  2. Click a row to open the left Drawer
  3. Expand an accordion under the "Data uses" section
  4. There are 4 fields here using the new Select (these may or may not be disabled)
  1. Go to Taxonomy management (/taxonomy)
  2. Switch to the Data Subjects tab
  3. Click the [Add Taxonomy Entity] button
  4. the "Rights" field is using the new Select
  1. Go to Connection manager (AKA Unlinked connections /datastore-connection)
  2. Click the [Create new connection] button
  3. The "Show all" connector type filter uses the new Select
  4. Search for "Manual"
  5. Click the "Manual Process" option
  6. Give it a name and click Save
  7. the "Data Categories" field uses the new Select

Pre-Merge Checklist

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗ī¸Ž

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview đŸ’Ŧ Add feedback Nov 21, 2024 8:33pm
cypress[bot] commented 1 week ago

fides    Run #11139

Run Properties:  status check passed Passed #11139  •  git commit 4a2835dfd4 ℹī¸: Merge 016b2f01f7df725ed74125e8d2582554a1e28277 into d1baca99b58d9c13d5e99d23a94f...
Project fides
Branch Review refs/pull/5502/merge
Run status status check passed Passed #11139
Run duration 00m 37s
Commit git commit 4a2835dfd4 ℹī¸: Merge 016b2f01f7df725ed74125e8d2582554a1e28277 into d1baca99b58d9c13d5e99d23a94f...
Committer Jason Gill
View all properties for this run ↗ī¸Ž
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠ī¸ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗ī¸Ž
gilluminate commented 3 days ago

@jpople Thanks for finding that one-off select. It helped me find 2 more in the Privacy Requests table filter!

cypress[bot] commented 1 day ago

fides    Run #11156

Run Properties:  status check passed Passed #11156  •  git commit 43b434b6be: Migrate custom selects (Chakra -> Ant) (#5502)
Project fides
Branch Review main
Run status status check passed Passed #11156
Run duration 00m 38s
Commit git commit 43b434b6be: Migrate custom selects (Chakra -> Ant) (#5502)
Committer Jason Gill
View all properties for this run ↗ī¸Ž
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠ī¸ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗ī¸Ž