ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

Updating masking strict check to use config proxy #5512

Closed galvana closed 4 days ago

galvana commented 5 days ago

Description Of Changes

Updates the config lookup in SaaSQueryConfig.get_masking_request to use ConfigProxy. This was done so we can update the value of masking_strict from Fidesplus.

Steps to Confirm

  1. Tests should pass, functionality remains the same

Pre-Merge Checklist

vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/jFfMjEJ4tZZhLGNukjGykuBNwkGj)) | [Visit Preview](https://fides-plus-nightly-git-update-masking-strict-chec-96cbbb-ethyca.vercel.app) | | Nov 19, 2024 6:07pm |
cypress[bot] commented 5 days ago

fides    Run #11082

Run Properties:  status check passed Passed #11082  •  git commit 8fcfcfd279 ℹ️: Merge ed5378be985842e358968466a905666ba82fc7a2 into 8c59e5d3961d9e23206566f12192...
Project fides
Branch Review refs/pull/5512/merge
Run status status check passed Passed #11082
Run duration 00m 37s
Commit git commit 8fcfcfd279 ℹ️: Merge ed5378be985842e358968466a905666ba82fc7a2 into 8c59e5d3961d9e23206566f12192...
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎
cypress[bot] commented 4 days ago

fides    Run #11091

Run Properties:  status check passed Passed #11091  •  git commit 2321052827: Updating masking strict check to use config proxy (#5512)
Project fides
Branch Review main
Run status status check passed Passed #11091
Run duration 00m 42s
Commit git commit 2321052827: Updating masking strict check to use config proxy (#5512)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎