search

ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

LA 88 segment md5 override #5514

Closed Vagoasdf closed 3 days ago

Vagoasdf commented 4 days ago

Closes LA#88

Description Of Changes

Adds the Segment MD5 Hash integration Overrides, which uses a hash of the email identity instead of a dataset collection from a database.

Requires a personalized segment config to be used correctly

Code Changes

Steps to Confirm

  1. Download the Branch
  2. Download the paired Segment Personalized config from this paired PR
  3. Test a delete request

Pre-Merge Checklist

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗ī¸Ž

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview đŸ’Ŧ Add feedback Nov 20, 2024 5:48pm
cypress[bot] commented 4 days ago

fides    Run #11116

Run Properties:  status check passed Passed #11116  •  git commit 7f54b73c27 ℹī¸: Merge 69a32b8de712d1784de1134c536c5f66be7ae362 into 97edac0ea8d38631e25454825d21...
Project fides
Branch Review refs/pull/5514/merge
Run status status check passed Passed #11116
Run duration 00m 41s
Commit git commit 7f54b73c27 ℹī¸: Merge 69a32b8de712d1784de1134c536c5f66be7ae362 into 97edac0ea8d38631e25454825d21...
Committer Bruno Gutierrez Rios
View all properties for this run ↗ī¸Ž
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠ī¸ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗ī¸Ž
codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (6fc8086) to head (22679e1). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...rride_implementations/segment_request_overrides.py 50.00% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5514 +/- ## ========================================== + Coverage 78.88% 78.96% +0.07% ========================================== Files 388 389 +1 Lines 24428 24869 +441 Branches 2669 2746 +77 ========================================== + Hits 19270 19637 +367 - Misses 4644 4707 +63 - Partials 514 525 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

cypress[bot] commented 3 days ago

fides    Run #11117

Run Properties:  status check passed Passed #11117  •  git commit 4702281527: LA 88 segment md5 override (#5514)
Project fides
Branch Review main
Run status status check passed Passed #11117
Run duration 00m 40s
Commit git commit 4702281527: LA 88 segment md5 override (#5514)
Committer Bruno Gutierrez Rios
View all properties for this run ↗ī¸Ž
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠ī¸ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗ī¸Ž