search

ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

LA-141 Apply privacy policy override even when locale doesn't match #5515

Closed lucanovera closed 3 days ago

lucanovera commented 4 days ago

Description Of Changes

Apply privacy policy override even when locale doesn't match

Code Changes

Steps to Confirm

You can use fides-js-demo.html to test

  1. Make sure you have an experience setup, that has a Privacy policy link label & Privacy policy link URL .
  2. Add this code to the head to do some overrides <script> window.fides_overrides = { fides_override_language: "es", fides_privacy_policy_url: "https://ethyca.com", }; </script>
  3. Check that the privacy policy url is overriden even if the fides_override_language doesn't match or if it isn't present.

Pre-Merge Checklist

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗ī¸Ž

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview đŸ’Ŧ Add feedback Nov 20, 2024 2:19pm
cypress[bot] commented 4 days ago

fides    Run #11102

Run Properties:  status check passed Passed #11102  •  git commit c8b1b3da7e ℹī¸: Merge 8ced1717e0a322d2c0b9e453dfa2ce08936acea5 into 30c44648063eb2e6dd6d761bfb2b...
Project fides
Branch Review refs/pull/5515/merge
Run status status check passed Passed #11102
Run duration 00m 39s
Commit git commit c8b1b3da7e ℹī¸: Merge 8ced1717e0a322d2c0b9e453dfa2ce08936acea5 into 30c44648063eb2e6dd6d761bfb2b...
Committer Lucano Vera
View all properties for this run ↗ī¸Ž
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠ī¸ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗ī¸Ž
cypress[bot] commented 3 days ago

fides    Run #11106

Run Properties:  status check passed Passed #11106  •  git commit 5418cab86c: LA-141 Apply privacy policy override even when locale doesn't match (#5515)
Project fides
Branch Review main
Run status status check passed Passed #11106
Run duration 00m 38s
Commit git commit 5418cab86c: LA-141 Apply privacy policy override even when locale doesn't match (#5515)
Committer Lucano Vera
View all properties for this run ↗ī¸Ž
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠ī¸ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗ī¸Ž