ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

add loading state to Experience switches #5529

Closed gilluminate closed 1 day ago

gilluminate commented 2 days ago

Closes HJ-255

Description Of Changes

Note: This is almost exactly the same as #5489 but for the Experiences table.

Toggling the switches in the Experiences table can sometimes take a moment or two and we aren't giving any feedback to the user. Now that we have toggle switches with loading states (thanks, Ant!) let's take advantage of that.

https://www.loom.com/share/c4da372b70ab46d89c01324a24fa8e53

Code Changes

Steps to Confirm

  1. Visit Privacy experience page /consent/privacy-experience
  2. Toggle some notices and notice the spinner while it loads (even after the confirmation modal)

Pre-Merge Checklist

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/EjfFbcsqJtTRVrCatYJH2mW82LLm)) | [Visit Preview](https://fides-plus-nightly-git-gill-hj-255clone-enable-disable-ethyca.vercel.app) | | Nov 21, 2024 9:16pm |
cypress[bot] commented 2 days ago

fides    Run #11141

Run Properties:  status check passed Passed #11141  •  git commit c91fc02ef1 ℹ️: Merge b8b9ce2a72185065a90c78d94fd3f47a9d613723 into d1baca99b58d9c13d5e99d23a94f...
Project fides
Branch Review refs/pull/5529/merge
Run status status check passed Passed #11141
Run duration 00m 39s
Commit git commit c91fc02ef1 ℹ️: Merge b8b9ce2a72185065a90c78d94fd3f47a9d613723 into d1baca99b58d9c13d5e99d23a94f...
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎
cypress[bot] commented 1 day ago

fides    Run #11146

Run Properties:  status check passed Passed #11146  •  git commit f80dddb59f: add loading state to Experience switches (#5529)
Project fides
Branch Review main
Run status status check passed Passed #11146
Run duration 00m 39s
Commit git commit f80dddb59f: add loading state to Experience switches (#5529)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎