ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

Send property id and also override path. #5532

Closed tvandort closed 1 day ago

tvandort commented 2 days ago

Description Of Changes

Fetch correct experience when a privacy center property is being use. Add env variable to override use a specific property for the root domain (when no property paths are used).

Code Changes

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/A7cuebdNhBb2JpwkY2S4TwDe7bsd)) | [Visit Preview](https://fides-plus-nightly-git-pass-property-id-to-experi-2408cf-ethyca.vercel.app) | | Nov 22, 2024 6:30pm |
cypress[bot] commented 2 days ago

fides    Run #11155

Run Properties:  status check passed Passed #11155  •  git commit ebfa33e455 ℹ️: Merge 2a5bdc5e1db9fd87b8ca8b2903795d200374c345 into f80dddb59f1fdf36534a2069ff34...
Project fides
Branch Review refs/pull/5532/merge
Run status status check passed Passed #11155
Run duration 00m 41s
Commit git commit ebfa33e455 ℹ️: Merge 2a5bdc5e1db9fd87b8ca8b2903795d200374c345 into f80dddb59f1fdf36534a2069ff34...
Committer Tom Van Dort
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎
cypress[bot] commented 1 day ago

fides    Run #11158

Run Properties:  status check passed Passed #11158  •  git commit 955a866ed1: Send property id and also override path. (#5532)
Project fides
Branch Review main
Run status status check passed Passed #11158
Run duration 00m 39s
Commit git commit 955a866ed1: Send property id and also override path. (#5532)
Committer Tom Van Dort
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎