ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

LA-165: Fix taxonomy create endpoints #5533

Closed eastandwestwind closed 1 day ago

eastandwestwind commented 1 day ago

Closes https://ethyca.atlassian.net/browse/LA-165

Description Of Changes

Fides issues with Taxonomy create endpoints

Code Changes

Steps to Confirm

  1. Confirm no regressions- you should be able to create taxonomy elements using the Admin-UI:

    Screenshot 2024-11-22 at 6 01 35 PM
  2. Confirm you can create taxonomy elements without specifying a fides key, e.g:

Screenshot 2024-11-22 at 5 58 40 PM

Pre-Merge Checklist

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/AVsTrwMJxGH1HJv5kezppYBBHHJs)) | [Visit Preview](https://fides-plus-nightly-git-la-165-ethyca.vercel.app) | | Nov 22, 2024 7:02pm |
cypress[bot] commented 1 day ago

fides    Run #11157

Run Properties:  status check passed Passed #11157  •  git commit 405cf8950d ℹ️: Merge 9feeedc24cdb53e69f0e2446e607a77fdaecf356 into 43b434b6becf0d59afbef5221522...
Project fides
Branch Review refs/pull/5533/merge
Run status status check passed Passed #11157
Run duration 00m 39s
Commit git commit 405cf8950d ℹ️: Merge 9feeedc24cdb53e69f0e2446e607a77fdaecf356 into 43b434b6becf0d59afbef5221522...
Committer Catherine Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎
cypress[bot] commented 1 day ago

fides    Run #11161

Run Properties:  status check passed Passed #11161  •  git commit f4ad7467bd: LA-165: Fix taxonomy create endpoints (#5533)
Project fides
Branch Review main
Run status status check passed Passed #11161
Run duration 00m 39s
Commit git commit f4ad7467bd: LA-165: Fix taxonomy create endpoints (#5533)
Committer Catherine Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎