ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
361 stars 72 forks source link

Change brand link to show in CMP modal and privacy center by default #5534

Open jpople opened 5 days ago

jpople commented 5 days ago

Closes HJ-182

Description Of Changes

Changes Fides brand link in CMP modal and privacy center to be enabled by default rather than dependent on env variable.

Steps to Confirm

  1. Remove FIDES_PRIVACY_CENTER__SHOW_BRAND_LINK from your .env
  2. Verify "powered by" brand link shows in privacy center
  3. Verify "powered by" brand link shows in CMP modal

Pre-Merge Checklist

vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fides-plus-nightly** | ⬜️ Ignored ([Inspect](https://vercel.com/ethyca/fides-plus-nightly/7eteiVKCmnufkyZdQrV5HzxQoQz1)) | [Visit Preview](https://fides-plus-nightly-git-jpople-hj-184show-brand-li-ed1caa-ethyca.vercel.app) | | Nov 22, 2024 5:26pm |
cypress[bot] commented 5 days ago

fides    Run #11153

Run Properties:  status check passed Passed #11153  •  git commit 6f184d4111 ℹ️: Merge 99517b7939da15fc14429e4eaeb42f19d186fc2a into f80dddb59f1fdf36534a2069ff34...
Project fides
Branch Review refs/pull/5534/merge
Run status status check passed Passed #11153
Run duration 00m 39s
Commit git commit 6f184d4111 ℹ️: Merge 99517b7939da15fc14429e4eaeb42f19d186fc2a into f80dddb59f1fdf36534a2069ff34...
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎