search

ethyca / fides

The Privacy Engineering & Compliance Framework
https://ethyca.com/docs
Apache License 2.0
360 stars 72 forks source link

Standardize error handling for dataset API #803

Closed ssangervasi closed 2 years ago

ssangervasi commented 2 years ago

I went looking for a related info fidesops but couldn't pin down what you meant. Maybe create an issue to document or implement this.

_Originally posted by @ssangervasi in https://github.com/ethyca/fides/pull/782#discussion_r903174350_

allisonking commented 2 years ago

Oh right, more context here: https://github.com/ethyca/fides/pull/772#discussion_r900690619

Basically I believe we want to marshal our error responses through type predicates in order for the code to know what type of error we received and how to display it. I did this on the fidesops side (really I was just trying to fix linting, but typescript was unhappy about the error parsing, so I went down this rabbit hole) https://github.com/ethyca/fidesops/blob/main/clients/admin-ui/src/features/common/helpers.ts

allisonking commented 2 years ago

Closed by https://github.com/ethyca/fides/pull/896