search

ethyl2 / worry-dolls

An app to help with mental health with a worry doll theme
https://ethyl2.github.io/worry-dolls/
MIT License
3 stars 3 forks source link

Redesign #17

Closed myckgoncalves closed 1 year ago

myckgoncalves commented 1 year ago

First, I confess that it is the first time hear about these dolls, loved it. :smiley:

I made big changes to the project, there were many corrections to make, there are still some, I intend to help more in the project but this is my contribution if accepted, sorry for the removal of some things, it was necessary for the redesign.

I made some things ready for those who are already working on the logic part.

A suggestion would be to keep the project without dependency, less data for the user since it is a relatively simple project.

I'm open to suggestions dear code friends.

changes.webm

ethyl2 commented 1 year ago

This is looking great! I like how you have individual worry dolls, with names! :-) Looks like there are some merge conflicts that need to be resolved. Hopefully you can resolve them, and keep the top nav that is now part of the site. I think it would be best if each worry doll had one worry, so you could take out the My worries (0) part. And we'd need to have the input open when the user clicks on 'tell' and then save to the correct doll. And if would be great to have more dolls, too, in the future.

myckgoncalves commented 1 year ago

This is looking great! I like how you have individual worry dolls, with names! :-) Looks like there are some merge conflicts that need to be resolved. Hopefully you can resolve them, and keep the top nav that is now part of the site. I think it would be best if each worry doll had one worry, so you could take out the My worries (0) part. And we'd need to have the input open when the user clicks on 'tell' and then save to the correct doll. And if would be great to have more dolls, too, in the future.

Glad you liked it Each doll can only have 1 worry? or did i get it wrong? If the doll can only have 1 worry, it really doesn't make sense to have the "My worries (0)", I thought the same doll could have multiple worries :sweat_smile:, and then the user would click to list the worries for each doll.

A question is regarding tailwind, I saw that the top nav that was just merged is using tailwind too, I wrote the redesign without using tailwind, and I saw that the tailwindcss tag was placed in the project, my code is not following the pattern... this is a problem. In my opinion, it would be ideal for us to follow a pattern, unfortunately my code does not fit the pattern established by the project.

ethyl2 commented 1 year ago

When my parents gave me my worry dolls, they told me I should give each doll one worry. And that made sense, because they came in a box with a handful of dolls. But reading more about them now, as an adult, it sounds like that's not always the case, to do just one worry per doll. So we could do it either way.

On Oct 13, 2022, at 11:16 PM, Myck Gonçalves @.***> wrote:

 This is looking great! I like how you have individual worry dolls, with names! :-) Looks like there are some merge conflicts that need to be resolved. Hopefully you can resolve them, and keep the top nav that is now part of the site. I think it would be best if each worry doll had one worry, so you could take out the My worries (0) part. And we'd need to have the input open when the user clicks on 'tell' and then save to the correct doll. And if would be great to have more dolls, too, in the future.

Glad you liked it Each doll can only receive 1 worry? or did i get it wrong? If the doll can only have 1 worry, it really doesn't make sense to have the "My worries (0)", I thought the same doll could have multiple worries 😅, and then the user would click to list the concerns for each doll, I will remove it.

I see now that a top nav has been merged, I will resolve the conflicts

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.