Closed Jaeyoung-Lim closed 3 years ago
Can one of the admins verify this patch?
@hitimo Any chance you can review this? Thanks in advance
add to whitelist
@Jaeyoung-Lim So, I have already Jenkins set up for this repo. Please correct me if I am wrong, but adding github actions would just be redundant, or what is the benefit?
For Jenkins, one would just need to fix the following:
See failures here:
https://jenkins.asl.ethz.ch/job/aerial_mapper/3368/lagopus-trusty=ubuntu-xenial-heavy/parsed_console/
grid_map: CMake 3.5.1 or higher is required. You are running version 2.8.12.2
https://jenkins.asl.ethz.ch/job/aerial_mapper/3368/lagopus-trusty=ubuntu-trusty-heavy/parsed_console/
Could not find a package configuration file provided by "protobuf_catkin"
@hitimo Thanks for the review. There are two parts of this PR, which is separated by two commits
If you think that adding a github actions doesn't fit in this repo, I am also fine with removing it from this PR. However, I still think the build issue is a real failure and needs to be fixed.
@Jaeyoung-Lim So, I have already Jenkins set up for this repo. Please correct me if I am wrong, but adding github actions would just be redundant, or what is the benefit?
I do see benefits on using github actions(less maintanance, more transparent and instant feedback), but the decision is yours as you are the main maintainer of the repo. Since Jenkins is also quite powerful I am fine with removing the pipeline from this PR, as long as the Jenkins CI is well maintained.
Ok, let's try out github actions and see how well it works, we can always go back to Jenkins. I've removed the Jenkins webhook. Thanks @Jaeyoung-Lim
@hitimo Thanks!
Problem Description This PR adds the a build fix which seems to be caused by a regression coming from a aslam_cv2 update. The fix has been mentioned in https://github.com/ethz-asl/aerial_mapper/issues/43 and is included in this PR
To prevent this from happening a gain, a github actions CI has been added which verifies the build in the following Ubuntu distributions. The Jenkins build pipeline uisng Jenkins seems to be not running anymore.
Additional Context