Closed Skype-line closed 3 years ago
Thanks for submitting this PR :)
I am not sure if you saw this, but I changed the structure of this repository a bit. This is mostly to support the use within ROS on the robot. I don't want to bother you too much with this, but here is the important part for you:
- all the python implementations are in
src/
. There is a python modulebfseg
where all functions and implementations should go, and then you can put training scripts etc. intosrc/
.- I already put the old versions of your files into this structure, so I think you are pretty much done by just copying the file contents into the structure (right now your updates are in
/
.- To use implementations like the dataset, use
cd src; pip install -e .
to install the module and then it should work that you can import the dataset from everywere withimport bfseg.data.nyu.nyu_depth_v2_labeled
.- I set up all configurations to use the yapf autoformatter. It should be easy to integrate with sublime, vscode or any editor that you use and will automatically format the code nicely. As you can see on the bottom of this page there is also an automatic check for formatting, so we can make sure that all code looks the same and is easy to read for everybody.
Sorry that this is a bit annoying. Hopefully you will profit from this integration towards the end of the thesis as it will be easy to learn on data from the real robot.
Sure. I didn't notice the old code in src/ folder. I will put new one there.
That looks good, thank you! The style checker is still complaining on a few parts (https://jenkins.asl.ethz.ch/job/background-foreground-segmentation_linter/28/label=mapcompute-bionic/console you can see it when clicking on details, then the big blue link on the center of the page, then console output). Could you try to get yapf to run on your machine and let it go over the documents?
That looks good, thank you! The style checker is still complaining on a few parts (https://jenkins.asl.ethz.ch/job/background-foreground-segmentation_linter/28/label=mapcompute-bionic/console you can see it when clicking on details, then the big blue link on the center of the page, then console output). Could you try to get yapf to run on your machine and let it go over the documents?
I think it works now.
@Skype-line I think your IDE is somehow creating files that should not be committed: https://jenkins.asl.ethz.ch/job/background-foreground-segmentation_linter/95/label=mapcompute-bionic/console
Thanks for submitting this PR :)
I am not sure if you saw this, but I changed the structure of this repository a bit. This is mostly to support the use within ROS on the robot. I don't want to bother you too much with this, but here is the important part for you:
src/
. There is a python modulebfseg
where all functions and implementations should go, and then you can put training scripts etc. intosrc/
./
.cd src; pip install -e .
to install the module and then it should work that you can import the dataset from everywere withimport bfseg.data.nyu.nyu_depth_v2_labeled
.Sorry that this is a bit annoying. Hopefully you will profit from this integration towards the end of the thesis as it will be easy to learn on data from the real robot.