ethz-asl / cad-percept

Bringing meshes to robotics.
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

CGAL <-> Eigen conversions #16

Closed hermannsblum closed 5 years ago

hermannsblum commented 5 years ago

as was previously part of the architect model in cadify

jstiefel commented 5 years ago

@hermannsblum Since we don't have any dependencies on Eigen in cgal_conversions, does it make more sense to add these in cpt_utils or add Eigen dependencies to cgal_conversions?

hermannsblum commented 5 years ago

let's add the eigen dependency to cgal_conversions for now, we can see later if we need to declutter.

jstiefel commented 5 years ago

I started a new branch (feature/cgal_eigen_conversions) for adding CGAL<->Eigen conversions in eigen_conversions.cc of cgal_conversions. Feel free to add functions:

https://github.com/ethz-asl/cad-percept/tree/feature/cgal_eigen_conversions

hermannsblum commented 5 years ago

@jstiefel You can do a PR for the 2 conversion functions right away, that is actually nicer than waiting for a big chunk