search

ethz-asl / cad-percept

Bringing meshes to robotics.
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

clang-format linting with jenkins #26

Closed hermannsblum closed 5 years ago

ethzasl-jenkins commented 5 years ago

Test PASSed.

ethzasl-jenkins commented 5 years ago

Test FAILed.

hermannsblum commented 5 years ago

Run Tests

hermannsblum commented 5 years ago

retest this please

ethzasl-jenkins commented 5 years ago

Test FAILed.

ethzasl-jenkins commented 5 years ago

Test PASSed.

hermannsblum commented 5 years ago

retest this please

ethzasl-jenkins commented 5 years ago

Test PASSed.

ethzasl-jenkins commented 5 years ago

Test FAILed.

hermannsblum commented 5 years ago

retest this please

ethzasl-jenkins commented 5 years ago

Test FAILed.

ethzasl-jenkins commented 5 years ago

Test PASSed.

ethzasl-jenkins commented 5 years ago

Test FAILed.

ethzasl-jenkins commented 5 years ago

Test FAILed.

ethzasl-jenkins commented 5 years ago

Test PASSed.

ethzasl-jenkins commented 5 years ago

Test FAILed.

ethzasl-jenkins commented 5 years ago

Test FAILed.

ethzasl-jenkins commented 5 years ago

Test PASSed.

ethzasl-jenkins commented 5 years ago

Test FAILed.

ethzasl-jenkins commented 5 years ago

Test PASSed.

ethzasl-jenkins commented 5 years ago

Test PASSed.

ethzasl-jenkins commented 5 years ago

Test PASSed.

hermannsblum commented 5 years ago

@michaelpantic @gawela This PR adds clang-format linting according to the stylesettings in .clang-format to the repository and reformats all files.
It basically therefore enforces auto-formatting.

The styles we have been using to far are:

BasedOnStyle: Google
ColumnLimit: 80

Let me know whether we should change that style or whether you oppose the whole idea.

hermannsblum commented 5 years ago

@gawela @michaelpantic ping, I would like to hear your opinions.

michaelpantic commented 5 years ago

@hermannsblum Nice, ill also try it out on my current branch/PR! Should we set the enforced character limit to 120? With all the typedefing going on in CGAL + strict enforcement, 80 seems a bit tight - what do you think?

michaelpantic commented 5 years ago

@hermannsblum also pretty nice that it directly generates a patch file in the log that can be applied... :+1:

hermannsblum commented 5 years ago

I'm all in favor of longer lines, but Abel was very particular about this. Maybe we can meet at 100? :smile:

It does provide a patch file, but actually you can install clang-format also as an autoformatter locally that will e.g. format your code automatically at every save, so you don't have to think about correct formatting at all.

michaelpantic commented 5 years ago

Yeah maybe lets put the hard-limit for check in at 100, but in general keep the style at 80. And use the 100 in case some really unfavorable line-breaking needs to be done. :+1:

Regarding the linter: interestingly I'm using the built in one of Clion with google style, but they seem to disagree on a few things. If I figure out why I'll document it somehwere.. otherwise I'll use clang-format locally ;-)

Anyway thanks for setting this up!

michaelpantic commented 5 years ago

BTW do you know why github indefinitely waits for jenkins? Screenshot_2019-08-28_12-50-22

hermannsblum commented 5 years ago

BTW do you know why github indefinitely waits for jenkins?

I changed the display names for the 2 jenkins pipelines to more descriptive names, but this branch still ran on the old pipeline so it is waiting for Jenkins Build Test, which was previously just Jenkins

ethzasl-jenkins commented 5 years ago

Test PASSed.