IDs are unique strings and no longer indizes to a list of faces

ethz-asl / cad-percept

Bringing meshes to robotics.

BSD 3-Clause "New" or "Revised" License

5 stars 1 forks source link

IDs are unique strings and no longer indizes to a list of faces #53

Closed hermannsblum closed 5 years ago

hermannsblum commented 5 years ago

This PR introduces the following changes:

IDs of Triangles can be arbitrary strings and are nto used as inidzes, but as lookup keys into the MeshModel, which keeps track of which ID is which Triangle.
Reads in Meshes with IDs from .json files
TriangleMeshMsg optionally contains IDs for triangles and vertices

This fixes #50

ethzasl-jenkins commented 5 years ago

Test FAILed.

ethzasl-jenkins commented 5 years ago

Test FAILed.

hermannsblum commented 5 years ago

@michaelpantic @gawela This PR is incompatible with ubuntu 16.04, as using some c++17 features made it much nicer. Do we require support for 16.04? Or should we just move to 18.04 on Jenkins?

hermannsblum commented 5 years ago

Test again.

hermannsblum commented 5 years ago

retest this please

ethzasl-jenkins commented 5 years ago

Test FAILed.

hermannsblum commented 5 years ago

Needed to update build preparation. retest this please

ethzasl-jenkins commented 5 years ago

Test FAILed.

ethzasl-jenkins commented 5 years ago

Test FAILed.

ethzasl-jenkins commented 5 years ago

Test FAILed.

ethzasl-jenkins commented 5 years ago

Test FAILed.