search

ethz-asl / cad-percept

Bringing meshes to robotics.
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

Comment clean up and renaming #68

Closed jstiefel closed 4 years ago

jstiefel commented 5 years ago

Just some clean up with better function explanations and some renaming to make it congruent with my thesis. Not tested yet since I somehow got locked out when you decided to change to Ubuntu 18.04 ;-). Would be nice if we can merge this before Wednesday.

PS: Even if it seems like I deleted some stuff, I just moved it to a better place in the same file. Did not delete anything.

ethzasl-jenkins commented 5 years ago

Test FAILed.

hermannsblum commented 5 years ago

First of all thanks for going through it again and putting in all the effort to clean up stuff :)

There are still some style problems and we seem to have a dependency issue with cgal_catkin (I guess independently from this PR). I will not be able to try it out before Wednesday, maybe @gawela can check?

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.