search

ethz-asl / cad-percept

Bringing meshes to robotics.
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

Matching of Detected Objects #95

Closed gasserl closed 4 years ago

gasserl commented 4 years ago

Package to align a point cloud from an object detection with the given mesh of the object. The matching is based on PCA to obtain an initial transformation which is refined using ICP.

Note: Dw, the actual additions are only 568, excluding off and rviz files

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

gasserl commented 4 years ago

Most comments have been addressed. The integration of meshes is in PR #97 for better readability of the changes. What would be a good branch to merge into until the restructuring of the repository is in master? The package minkindr_conversions is a new dependency, with which jenkins seems to struggle in the build test. What is the easiest way to format the code appropriately? I'm not very experienced with linter and such yet.

gawela commented 4 years ago

Just read the response. Regarding the branch, it would be best to open a develop branch that you can treat as your master for the time being. The failing build seems odd, please check with one of the jenkins admins.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

gasserl commented 4 years ago

I've created the branch devel/major_cleanup and changed the base of this PR to the new branch. The package is in the localization module. The comments should be addressed and Jenkins is fixed as well. Hopefully, everything is ready to be merged now. PR #97 is still open, in case you would prefer to merge that into this branch first.

gawela commented 4 years ago

This looks good to me. The devel/major cleanup branch was merged into master in the meantime, so you can also make master the base branch and merge.