ethz-asl / cad-percept

Bringing meshes to robotics.
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

Convert `architect_model::ArchitectModel` to `cad_percept::cgal::MeshModel` #98

Closed francescomilano172 closed 4 years ago

francescomilano172 commented 4 years ago

A smaller pull request so that the localization module uses cad_percept::cgal::MeshModel rather than architect_model::ArchitectModel. The previous commits on the branch fmilano/cpt_pointlaser_loc are essentially just a refactoring of the code from the hilti_slam repo (will open a PR for the whole branch after implementing the ROS interface, which is still missing). The changes below assume that:

I wasn't sure where to place the new function buildRayFromPose (please cf. cfa0cc7 for a description of why it is required), so I inserted it in the cpt_utils package, which seems to contain methods with a similar functionality.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

francescomilano172 commented 4 years ago

retest this please

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

francescomilano172 commented 4 years ago

@gawela Thanks a lot for the review! The style checker was also complaining about the length of some lines (I was using max length 80 locally, instead of the 100 set in the .clang-format). Merging (into fmilano/cpt_pointlaser_loc).