updated all pass-by-ref outputs to be pointers

ethz-asl / curves

A library of curves for estimation.

BSD 3-Clause "New" or "Revised" License

74 stars 28 forks source link

Closed sanderson77 closed 10 years ago

sanderson77 commented 10 years ago

Changes have to do with moving style towards pointer outputs for readability

I had some person debate on this change:

virtual Eigen::VectorXd* makeUniqueInPlace(Eigen::VectorXd* thisCoeff) const = 0;

Should we maintain that inplace functions have a return, in order to enable method chaining? or change return to void?

furgalep commented 10 years ago

Good question above, Sean.

I think I was over optimizing. Let's go to void return types.

Update that and it lgtm (looks good to me)