Closed sanderson77 closed 10 years ago
Changes have to do with moving style towards pointer outputs for readability
I had some person debate on this change:
virtual Eigen::VectorXd* makeUniqueInPlace(Eigen::VectorXd* thisCoeff) const = 0;
Should we maintain that inplace functions have a return, in order to enable method chaining? or change return to void?
Good question above, Sean.
I think I was over optimizing. Let's go to void return types.
Update that and it lgtm (looks good to me)
Changes have to do with moving style towards pointer outputs for readability
I had some person debate on this change:
Should we maintain that inplace functions have a return, in order to enable method chaining? or change return to void?