search

ethz-asl / curves

A library of curves for estimation.
BSD 3-Clause "New" or "Revised" License
74 stars 28 forks source link

Rename Time to NsecTime #16

Closed furgalep closed 10 years ago

furgalep commented 10 years ago

I think this makes it more clear that time is integer nanoseconds.

Anyone disagree?

markusachtelik commented 10 years ago

not sure, is it really convenient to do math with it? I assume we're going to do more complex things than just adds ...

rdube commented 10 years ago

I think that a simple comment next to the definition of Time should do the trick.

pomerlef commented 10 years ago

We agreed in RoboChunk to have 32-bit integers x2 for a total of 64 bits.

https://github.com/ethz-asl/robochunk/issues/10

I'm about to add time in libpointmatcher and this is part of the common interface. Treat that carefully.

furgalep commented 10 years ago

Are we good to go sticking with 64-bit integer nanoseconds since epoch?

pomerlef commented 10 years ago

for me, as long as we are coherent through the different projects, 64-bit integer is fine.