search

ethz-asl / curves

A library of curves for estimation.
BSD 3-Clause "New" or "Revised" License
74 stars 28 forks source link

Template the top level curve on value type #3

Closed furgalep closed 10 years ago

furgalep commented 10 years ago

I have a first implementation of this. Some parts are probably wrong but please ask me about any design decisions.

HannesSommer commented 10 years ago

I like it :). Except an identifier decision: I don't think "Typed" is a good prefix because it is quite meaningless or misleading. "Templated" would be even more adequate but still bad. Best would be a modifier that refers to the features we gain. Like "EvaluableCurve". If we don't find a good name there we could have the Typed* classes being plainly named (so e.g. TypedCurve -> Curve) and then give the non templated base classes the modified names. (e.g. CurveBase or GeneralCurve). I currently believe we will more often have to deal with the templated type than the base type, which would support the latter. But I'm not sure. Oh my, there should be a good convention about how to name such things. Any opinions?

furgalep commented 10 years ago

I like CurveBase and Curve<Config>

furgalep commented 10 years ago

I will change that.

furgalep commented 10 years ago

Done.