search

ethz-asl / curves

A library of curves for estimation.
BSD 3-Clause "New" or "Revised" License
74 stars 28 forks source link

First steps toward tight gtsam integration #38

Closed furgalep closed 9 years ago

furgalep commented 9 years ago

Although...there is a big problem with this. If we are using a bleeding-edge gtsam, we need to get this on to the build server somehow. But I'm not sure how to do this.

@simonlynen is there an underlay workspace on the build server where I can add the bleeding edge gtsam?

furgalep commented 9 years ago

test this please

furgalep commented 9 years ago

test this please

furgalep commented 9 years ago

test this please

furgalep commented 9 years ago

test this please

simonlynen commented 9 years ago

lgtm

furgalep commented 9 years ago

test this please

furgalep commented 9 years ago

test this please

furgalep commented 9 years ago

@mikebosse did you see this? I'm going to merge.

mikebosse commented 9 years ago

lgtm

On Tuesday, October 21, 2014, Paul Furgale notifications@github.com wrote:

@mikebosse https://github.com/mikebosse did you see this? I'm going to merge.

— Reply to this email directly or view it on GitHub https://github.com/ethz-asl/curves/pull/38#issuecomment-59987824.

simonlynen commented 9 years ago

@furgalep This first has to be approved by the mac-mini :)

simonlynen commented 9 years ago

test this please

mikebosse commented 9 years ago

@HannesSommer had a good idea to protect versions of curves with and without gtsam from interfering with one another if they were ever to be linked in the same object.

When GTSAM is enabled, put all the code in to the namespace gtsam::curves and make a namespace alias: namespace curves = gtsam::curves; then the symbols to the linker will be different, but the programmer doesn't have to worry about different namespaces.

furgalep commented 9 years ago

This PR is probably not needed any more?

rdube commented 9 years ago

The changes in the following files were merged in PR #40 :

curves/CMakeLists.txt curves/cmake/curves-extras.cmake.in curves/package.xml

Changes in curves/include/curves/Coefficient.hpp were not merged since it relied on <gtsam/base/DerivedValue.h> which is out of date.