search

ethz-asl / curves

A library of curves for estimation.
BSD 3-Clause "New" or "Revised" License
74 stars 28 forks source link

Feature/discrete se3 curve #58

Closed rdube closed 8 years ago

rdube commented 8 years ago

@gawela @pfankhauser @HannesSommer I would eventually like to merge that branch in. PR #54 and #57 should be done before as they are intermediate steps.

@pfankhauser I see that you have been developing on a branch for quite some time. Would it make sense to merge together? Did you remove the gtsam dependencies?

Cheers!

rdube commented 8 years ago

"LGTM" aside from that Jenkins complaining.

pfankhauser commented 8 years ago

@rdube What's the state on this? Yes, I forked curves into our private Bitbucket repo, removed the dependencies in GSTAM, and used kindr instead of minkindr. Of course I'd be happy to share. BTW, kindr is getting an overhaul with a bunch of usage simplifications (see branch), so it might be worth to have another look at it. I think it's easiest if we talk in person. Thanks!

rdube commented 8 years ago

@pfankhauser I understand that curves and mincurves diverged quite a lot! ;-) Yes let's discuss this in person one day soon.

pfankhauser commented 8 years ago

@rdube I don't think it's diverged that far, so updating it with your enhancements should be straight forward. Also, I wrote a curves_ros to autmatically convert ROS trajectory messages into curve's representation.

rdube commented 8 years ago

test this please

rdube commented 8 years ago

test this please

rdube commented 8 years ago

test this please

rdube commented 8 years ago

@gawela I'll try a bit more to fix the testing errors on osx. Would you agree to merge once the tests are passed on Jenkins?

gawela commented 8 years ago

@rdube totally agree!

rdube commented 8 years ago

Good!