search

ethz-asl / curves

A library of curves for estimation.
BSD 3-Clause "New" or "Revised" License
74 stars 28 forks source link

Fixing compilation in Debug mode. #65

Open pfankhauser opened 7 years ago

pfankhauser commented 7 years ago

This fixes the unit quaternion check when building in Debug, however it breaks the unit test at

/home/peter/catkin_ws/src/curves/curves/test/CubicHermiteSE3CurveTest.cpp:261:

Couldn't figure out what goes wrong here, any ideas?

ethzasl-jenkins commented 7 years ago

Can one of the admins verify this patch?

rdube commented 7 years ago

@pfankhauser isn't Jenkins setup to verify PRs? I'll try on my machine.

rdube commented 7 years ago

@pfankhauser I get the same issue, with the rotational part failing. Which part of the modif did solve the building in debug? The new construction of the w1_dbeta1 ... objects or the construction of qDiff with normalization? Are you sure that both modifs are needed and maybe we can use this to isolate? Also which constructor of https://github.com/ethz-asl/kindr/blob/9a0d954636278e79b62e21a2ea4d7d664265f5be/include/kindr/rotations/RotationQuaternion.hpp#L55 is used? I could not find one taking a 3x1 eigen matrix.

pfankhauser commented 7 years ago

@dbellicoso what's the state of this with your latest fixes?

helenol commented 6 years ago

add to whitelist

HannesSommer commented 6 years ago

I've killed the curves_tests on ibex-trusty after it had consumed > 700 minutes of CPU time...